Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pd-control: add new config of balance-hot-region-scheduler #6835

Merged
merged 5 commits into from
Aug 11, 2021
Merged

pd-control: add new config of balance-hot-region-scheduler #6835

merged 5 commits into from
Aug 11, 2021

Conversation

HunDunDM
Copy link
Contributor

Signed-off-by: HunDunDM [email protected]

First-time contributors' checklist

What is changed, added or deleted? (Required)

pd-control: add new config of balance-hot-region-scheduler

Related features are GA at v5.2.0.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 10, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn August 10, 2021 14:24
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 10, 2021
@HunDunDM HunDunDM added the v5.2 This PR/issue applies to TiDB v5.2. label Aug 10, 2021
@HunDunDM HunDunDM mentioned this pull request Aug 10, 2021
Merged
lhy1024
lhy1024 reviewed Aug 11, 2021
View reviewed changes
pd-control.md Outdated Show resolved Hide resolved
lhy1024
lhy1024 reviewed Aug 11, 2021
View reviewed changes
Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rest LGTM

pd-control.md Outdated Show resolved Hide resolved
@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. status/require-change Needs the author to address comments. and removed missing-translation-status This PR does not have translation status info. labels Aug 11, 2021
TomShawn
TomShawn reviewed Aug 11, 2021
View reviewed changes
pd-control.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Aug 11, 2021
View reviewed changes
pd-control.md Outdated Show resolved Hide resolved
@HunDunDM
address comment
113134a 
Signed-off-by: HunDunDM <[email protected]>
@HunDunDM HunDunDM requested a review from nolouch August 11, 2021 04:43
@TomShawn TomShawn removed the status/require-change Needs the author to address comments. label Aug 11, 2021
@ti-chi-bot
Copy link
Member

@lhy1024: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@HunDunDM
tiny fix
2eb4507 
Signed-off-by: HunDunDM <[email protected]>
@ti-chi-bot
Copy link
Member

@nolouch: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn
TomShawn approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 11, 2021
@TomShawn
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 11, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2eb4507

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 11, 2021
@ti-chi-bot ti-chi-bot merged commit 6779473 into pingcap:master Aug 11, 2021
@HunDunDM HunDunDM deleted the pd-ctl-sche-config branch August 11, 2021 05:38
@lhy1024 lhy1024 mentioned this pull request Aug 12, 2021
Merged
This was referenced Aug 12, 2021
Merged
Merged
Merged
Merged
@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Aug 12, 2021
Merged
11 tasks
@Liuxiaozhen12 Liuxiaozhen12 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@nolouch nolouch nolouch approved these changes

Assignees

@Liuxiaozhen12 Liuxiaozhen12

Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.2 This PR/issue applies to TiDB v5.2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@HunDunDM @ti-chi-bot @TomShawn @nolouch @lhy1024 @Liuxiaozhen12